-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mpi4py/failing deepspeed test issues #2353
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this ! Why do we need conda install
? It is possible to do apip install
? I don't like mixing pip and conda. However, I think it is fine as long as you use pip after conda. See related doc.
@SunMarc it's a very specific |
We also do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @muellerzr for fixing this difficult to debug issue, great investigation. ✨
* Try deepspeed after installing mpi4py * Try again * Just GPU needed * Run slow deepspeed * Fin * Uncomment * Uncomment x2
What does this PR do?
Solves the issue of #2350,
mpi4py
needed to beconda installed
in the image, so this PR updates the docker image to do so (since currently we don't have docker images sanctioned by subject and it's just one with everything)You can see it passing here: https://github.com/huggingface/accelerate/actions/runs/7571310090
Fixes # (issue)
Failing nightly test
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@pacman100 @SunMarc